-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LWP optional. #408
Merged
Merged
Make LWP optional. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eliminates the XS dependency in Plack. LWP::UserAgent (which requires HTML::Parser as its only XS dependency) is used inside Plack::Test, and this patch makes this dependency optional and skip tests when LWP::UserAgent is not avaialable. This might break some cases where Plack::Test is used outside .t (highly unlikely) or where $Plack::Test::Impl is flipped through MockHTTP and then Server. If you put Server first in the flip (like this commit), the tests will skip immediately and there won't be an issue.
Starlet: PR sent kazuho/Starlet#10 |
…onment for each module.
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Jan 13, 2015
0.24 - worker processes always receive different sequence of values when calling "rand()" 0.23 - serialize calls to select -> accept when listening to multiple ports 0.22 - listen to multiple ports passed from Server::Starter (ttakezawa) 0.21 - support listening to unix socket (passed by Server::Starter) (kazeburo) 0.20 - support HTTP/1.1 (kazeburo) 0.19 - update the dependencies now that Plack no more depends on LWP (miyagawa; plack/Plack#408) - add support for psgix.harakiri (audreyt)
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Jan 18, 2015
0.24 - worker processes always receive different sequence of values when calling "rand()" 0.23 - serialize calls to select -> accept when listening to multiple ports 0.22 - listen to multiple ports passed from Server::Starter (ttakezawa) 0.21 - support listening to unix socket (passed by Server::Starter) (kazeburo) 0.20 - support HTTP/1.1 (kazeburo) 0.19 - update the dependencies now that Plack no more depends on LWP (miyagawa; plack/Plack#408) - add support for psgix.harakiri (audreyt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eliminates the XS dependency in Plack.