Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LWP optional. #408

Merged
merged 3 commits into from
Jun 12, 2013
Merged

Make LWP optional. #408

merged 3 commits into from
Jun 12, 2013

Conversation

miyagawa
Copy link
Member

This eliminates the XS dependency in Plack.

This eliminates the XS dependency in Plack.

LWP::UserAgent (which requires HTML::Parser as its only XS dependency)
is used inside Plack::Test, and this patch makes this dependency
optional and skip tests when LWP::UserAgent is not avaialable.

This might break some cases where Plack::Test is used outside .t
(highly unlikely) or where $Plack::Test::Impl is flipped through
MockHTTP and then Server. If you put Server first in the flip (like
this commit), the tests will skip immediately and there won't be an
issue.
@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 478a2cc on lwp-optional into 0cda5b6 on master.

@miyagawa
Copy link
Member Author

Starlet: PR sent kazuho/Starlet#10
Starman: fixed miyagawa/Twiggy@fef741a
Twiggy: fixed miyagawa/Twiggy@fef741a

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 2d1ab7c on lwp-optional into 0cda5b6 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0%) when pulling 4dee6a8 on lwp-optional into 0cda5b6 on master.

miyagawa added a commit that referenced this pull request Jun 12, 2013
@miyagawa miyagawa merged commit a76f705 into master Jun 12, 2013
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jan 13, 2015
0.24
	- worker processes always receive different sequence of values when
	  calling "rand()"
0.23
	- serialize calls to select -> accept when listening to multiple ports
0.22
	- listen to multiple ports passed from Server::Starter (ttakezawa)
0.21
	- support listening to unix socket (passed by Server::Starter) (kazeburo)
0.20
	- support HTTP/1.1 (kazeburo)
0.19
	- update the dependencies now that Plack no more depends on LWP
          (miyagawa; plack/Plack#408)
	- add support for psgix.harakiri (audreyt)
jsonn pushed a commit to jsonn/pkgsrc that referenced this pull request Jan 18, 2015
0.24
	- worker processes always receive different sequence of values when
	  calling "rand()"
0.23
	- serialize calls to select -> accept when listening to multiple ports
0.22
	- listen to multiple ports passed from Server::Starter (ttakezawa)
0.21
	- support listening to unix socket (passed by Server::Starter) (kazeburo)
0.20
	- support HTTP/1.1 (kazeburo)
0.19
	- update the dependencies now that Plack no more depends on LWP
          (miyagawa; plack/Plack#408)
	- add support for psgix.harakiri (audreyt)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants