Add HTTP::Tiny interface for LWP replacement in tests #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
|
I fixed the usage of HTTP::Tiny (and its bug fixes ported to HTTP::Thin) and all the tests are now green on Travis and Mac OS X, even with parallel testing enabled. I think this is good to be merged, unless anyone at @plack/core disagrees. |
miyagawa
added a commit
that referenced
this pull request
Jun 13, 2013
Add HTTP::Tiny interface for LWP replacement in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like causing failure on most Travis environments. Pass fine locally, but also see failures if running parallel with -j, so there might be some unstability with HTTP::Tiny talking to local HTTP servers.
Also, see HTTP::Thin for the standalone module implementation of the same thing, but it has more dependencies and probably has bugs with repeated HTTP header values handling.