Flexible request body parser #434

Open
wants to merge 4 commits into
from

Conversation

Projects
None yet
3 participants
@tokuhirom
Member

tokuhirom commented Oct 23, 2013

No description provided.

tokuhirom added some commits Oct 23, 2013

New flexible request body parser.
- It's 100% compatible with older versions.
- User can add any body parser by himself.
- HTTP::MultiPartParser & URL::Encode is faster than HTTP::Body.
Make body parser as an object, instead of coderef.
- Remove backward compatible layer for HTTP::Body.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 23, 2013

Coverage Status

Coverage remained the same when pulling 1fac96a on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

Coverage Status

Coverage remained the same when pulling 1fac96a on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 23, 2013

Coverage Status

Coverage increased (+0.78%) when pulling 1fac96a on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

Coverage Status

Coverage increased (+0.78%) when pulling 1fac96a on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

lib/Plack/BodyParser/JSON.pm
+use strict;
+use warnings;
+use utf8;
+use 5.010_001;

This comment has been minimized.

@miyagawa

miyagawa Oct 30, 2013

Member

do you really need these?

@miyagawa

miyagawa Oct 30, 2013

Member

do you really need these?

This comment has been minimized.

@tokuhirom

tokuhirom Oct 30, 2013

Member

Oops. My vim snippet injected this. I removed this at 4a80f4e.

@tokuhirom

tokuhirom Oct 30, 2013

Member

Oops. My vim snippet injected this. I removed this at 4a80f4e.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 30, 2013

Coverage Status

Coverage increased (+0.77%) when pulling 4a80f4e on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

Coverage Status

Coverage increased (+0.77%) when pulling 4a80f4e on tokuhirom:flexble-parser-without-http-body into f168ddc on plack:master.

@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Feb 10, 2015

Member

I saw http://search.cpan.org/~kazeburo/HTTP-Entity-Parser-0.12/lib/HTTP/Entity/Parser.pm and would love to replace HTTP::Body with a faster implementation like this. Is it still viable to update and merge this? cc @kazeburo

See also: @chansen's URL::Encode::XS, HTTP::MessageParser and HTTP::MultipartParser.

cc @avar

Member

miyagawa commented Feb 10, 2015

I saw http://search.cpan.org/~kazeburo/HTTP-Entity-Parser-0.12/lib/HTTP/Entity/Parser.pm and would love to replace HTTP::Body with a faster implementation like this. Is it still viable to update and merge this? cc @kazeburo

See also: @chansen's URL::Encode::XS, HTTP::MessageParser and HTTP::MultipartParser.

cc @avar

@miyagawa

This comment has been minimized.

Show comment
Hide comment
@miyagawa

miyagawa Nov 14, 2015

Member

Duh, I completely forgot this PR and re-implemented everything with #537

Member

miyagawa commented Nov 14, 2015

Duh, I completely forgot this PR and re-implemented everything with #537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment