Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plack::Handler::FCGI - Support Server::Starter #435

Merged
merged 2 commits into from
Oct 4, 2014
Merged

Conversation

yuryu
Copy link

@yuryu yuryu commented Oct 28, 2013

Hello,

I wrote a patch to make Plack::Handler::FCGI Server::Starter-aware.

I am not sure if this is the right place to do this. Maybe I should make a sub-class and do the staff there. Let me know there are any better ways to do this.

Thanks.

Support Server::Starter to allow hot-deploying in a defacto-standard manner.
It doesn't require Server::Starter module until SERVER_STARTER_PORT env is set.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.22%) when pulling 4bb93b8 on yuryu:master into f168ddc on plack:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.25%) when pulling 7136495 on yuryu:master into f168ddc on plack:master.

@tsibley
Copy link
Contributor

tsibley commented Mar 7, 2014

Any update on if this will get merged?

miyagawa added a commit that referenced this pull request Oct 4, 2014
Plack::Handler::FCGI - Support Server::Starter
@miyagawa miyagawa merged commit c02647d into plack:master Oct 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants