Make return of response_cb explicit rather than implicit. #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oalders
changed the title
This bit me earlier this week when I wasn't paying enough attention and included some logic in my call() method *after* calling response_cb(). There are other explicit returns in the code samples here. I think it wouldn't hurt to make it obvious that response_cb()'s return value needs to be returned by the Middleware.
miyagawa
added a commit
that referenced
this pull request
Nov 26, 2014
Make return of response_cb explicit rather than implicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bit me earlier this week when I wasn't paying enough attention and
included some logic in my call() method after calling response_cb().
There are other explicit returns in the code samples here. I think it
wouldn't hurt to make it obvious that response_cb()'s return value needs
to be returned by the Middleware.