Skip tests requiring fork() when no fork() is available #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you build perl on Windows without -DPERL_IMPLICIT_SYS (which I do, in order to enable -DPEL_MALLOC, which seems faster than using the system malloc()) then you don't get the fork() emulation and several of Plack's tests fail. This commit skips those tests in the same manner as various other CPAN modules do in this case. This allows a normal "cpan install ..." of Plack or anything depending on it (e.g. Dancer) to succeed without having to "force" anything.
|
Thanks for the patch. But obviously repeating this same code chunk in 13 test files, as well as possibly a few other distribution is considered not the great practice. I would suggest making this a Test:: module, so that we can inject in as a test requirement (like Test::Requires). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you build perl on Windows without -DPERL_IMPLICIT_SYS (which I do, in
order to enable -DPEL_MALLOC, which seems faster than using the system
malloc()) then you don't get the fork() emulation and several of Plack's
tests fail.
This commit skips those tests in the same manner as various other CPAN
modules do in this case. This allows a normal "cpan install ..." of
Plack or anything depending on it (e.g. Dancer) to succeed without having
to "force" anything.