Fix parsing of empty query string pairs better #501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the test to include empty pairs both at the start and in the middle of the string.
Also it avoids the check for empty pairs in every iteration of the
map
by splitting not just on single separators, but on sequences of any number of separators – then the split doesn’t produce empty pairs in the first place. The remaining exception is that it can still do so at the start of the string, so the code first throws away any sequence of leading separators.