Wrong default category

[KES777]

details here
#518

[miyagawa]

Do you have a test to verify this fix?

[KES777]

I have check seven times and it is actually has no matter what value is there. So I can write:
`$self->logger( Log::Log4perl->get_logger('asdfasdfasdf') );
And every thing work fine, because of none use this category setted up. this is useless code (for one exception)
I will explain later.

[miyagawa]

Well, by test I mean the unit test, such as the one we already have: t/Plack-Middleware/log4perl.t. If you can add a new test in that file to verify this fix, I will get it merged.

If that is difficult for you, let me know.

[KES777]

ok. I will do week or two later.

Corect me please if I wrong: it seems that 'category' option is useless at all, is not?

[KES777]

I correct myself: enable 'log4perl' is not requred for enable 'Debug', [qw/log4perl/]

So I fix error with '0' category and contribute to DOC.

use Modern::Perl;
use HTML::Mason::PSGIHandler;

my $app = sub {
    my $env =  shift;
    return [
        '200',
        [ 'Content-Type' => 'text/plain' ],
        [ "Hello World" ],
    ];
};

use Plack::Builder;
my $b =  builder {
    enable 'Log4perl';
    $app;
}

In this program without use Log::Log4perl (but it is not requried to have it at all) I get error:

Can't locate object method "get_logger" via package "Log::Log4perl" at /home/user/perl5/lib/perl5/Plack/Middleware/Log4perl.pm line 23

You use Log::Log4perl in your module. I think you should use Log::Log4perl instead of requre ...
or check Log::Log4perl instead of $self->conf and then requre if it not available yet.

[KES777]

If you can add a new test in that file to verify this fix, I will get it merged.

will you merge?

[miyagawa]

This PR has a lot more changes by just fixing the default category bug. You could make the code change as minimal, or I will cherry pick only the changes I think is fine, but that will take me a bit of time.

[KES777]

Oh, I am sorry. Different MR was mixed here.
I will try to revert those and make this PR clear.

[KES777]

Open new MR

[coveralls]

Changes Unknown when pulling cd44fc5 on KES777:master into ** on plack:master**.