Update Promise example in the README.md #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntindall
force-pushed
the
nt-update-readme.md
branch
from
e87f24c
to
30713dc
Compare
ntindall
force-pushed
the
nt-update-readme.md
branch
from
30713dc
to
e824c8f
Compare
ntindall
commented
Dec 9, 2017
| console.log(res.accounts); | ||
| }); | ||
| }).catch(err => { | ||
| // If error_type is null, it indicates a network or runtime error. |
There was a problem hiding this comment.
I believe this is the proper way to interact with the node client errors. @michaelckelly does this seem right to you?
Maybe we should export some sort of isPlaidError function from this package to make disambiguating plaid errors from runtime/network errors easier for clients.
ntindall
commented
Dec 10, 2017
| })); | ||
| app.use(bodyParser.json()); | ||
|
|
||
| app.post('/plaid_exchange', (req, res) => { |
There was a problem hiding this comment.
i think this would be cleaner as a coroutine but maybe we shouldn't be so opinionated in our examples.. i'm imagining that this should be copy/pastable.
michaelckelly
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.