Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified link so multiple react components can instantiate different … #28

Merged
merged 8 commits into from
Aug 28, 2019

Conversation

jlaramie
Copy link
Contributor

…plaid links

@cereallarceny
Copy link

@pbernasconi Any update?

@jlaramie
Copy link
Contributor Author

I went ahead and pulled the latest into my fork and pull request. I'm not too familiar with this process so let me know if I need to redo the pull request before merging.

@pawelmaczka
Copy link

@jlaramie I'm not sure why it is in the state. Can't it be just this.handler?

@jlaramie
Copy link
Contributor Author

@pawelmaczka State isn't necessary and could be just this.linkHandler

@AlbertoPL
Copy link

What would it take to get this merged in? It would be super useful for what I'm working on, and I'm sure for many others as well.

@jlaramie
Copy link
Contributor Author

@pawelmaczka I modified this to not use this.setState to hold the linkHandler. I also fixed the package.json referencing lib/ instead of dist/

@pbernasconi
Copy link
Contributor

Sorry that I have been unresponsive for this repo!

In the next few weeks, I'm planning to move this repo over to the official Plaid organization, and will be addressing this, and the other open issues then!

Stay tuned for an update soon.

@ericmmartin
Copy link

Hi @pbernasconi! Thanks for your work on this. Are there any updates on moving this to the Plaid org?

@jeffcoh23
Copy link

Would be awesome if this got merged soon! @pbernasconi

@jlaramie
Copy link
Contributor Author

@pbernasconi @jeffcoh23 This should be all good to go for a merge.

@jeffcoh23
Copy link

@jlaramie @pbernasconi any update?

@jlaramie
Copy link
Contributor Author

@jlaramie @pbernasconi any update?

I wish :)

@pbernasconi pbernasconi merged commit f48fed5 into plaid:master Aug 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants