-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TPP Runner Wrapper pass #905
Conversation
For TPP+IMEX testing, I settled on tpp-run but running tpp-opt with desired part of the pipeline is overall cleaner. |
The pass name is Do you aim to upstream this? |
No, I don't think it's generic enough for that. It stays internal for now.
Mostly for future integration with external tools. Change is motivated by the current use case of TPP -> IMEX pipeline: This separate runner wrapper pass allows to retain our handy wrappers and avoid silly errors when terminating lowering pipeline early. With this PR, the following is possible: It might or might not be useful in the future. But the worst case, this change simplifies our runner a bit by moving the wrapper into a separate logic (pass). Perhaps, we can give it a nicer name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. It's fine as is. If we want to upstream later, we can clean up.
Refactor MLIR Bench infrastructure into a pass. The core logic is already covered by tpp-run tests.
9c67e59
to
64a7608
Compare
NFC rebase on main + renamed to |
Refactor MLIR Bench infrastructure into a pass.
The core logic is already covered by tpp-run tests.