Use table row highlighting instead of images for deliniating query fr…

…agments. Fixes bug #11877.
plainblack · Sep 20, 2010 · 3f934ed · 3f934ed
1 parent 86ecb10
commit 3f934ed
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/docs/changelog/7.x.x.txt b/docs/changelog/7.x.x.txt
@@ -14,6 +14,7 @@
  - fixed #11866: Default ordering for Zip files is wrong
  - fixed: typo in the Gallery Add Archive default templateId.
  - fixed #11876: packing templates, snippets, headtags removes conditional CSS comments
+ - fixed #11877: Criteria Builder on "shortcut by alternate criteria" gets ugly with many checkbox items
 
 7.10.0
  - fixed #11812: Checking www_ajaxSave's response in the cart js, urlencoding post parameters

diff --git a/lib/WebGUI/Asset/Shortcut.pm b/lib/WebGUI/Asset/Shortcut.pm
@@ -105,8 +105,9 @@ sub _drawQueryBuilder {
 
 		# Table row with field info
         my $disabled = $self->{_disabled};
+        my $odd_row = $i % 2 ? q{class="qbtr_alt"} : "";
 		$output .= qq|
-		<tr>
+		<tr $odd_row>
 		<td class="qbtdleft"><p class="qbfieldLabel">$fieldLabel</p></td>
 		<td class="qbtd">
 		$opField

diff --git a/www/extras/wobject/Shortcut/querybuilder.css b/www/extras/wobject/Shortcut/querybuilder.css
@@ -1,20 +1,22 @@
+.qbtr_alt {
+    background-color:#DCE4EE;
+}
+
 .qbtd {
-	height: 20px;
-	background-image: url(hline.gif);
 	padding-left: 5px;
 	padding-right: 5px;
+    height: 20px;
 }
 
 .qbtdleft {
-	height: 20px;
-	background-image: url(hline.gif);
 	padding-right: 5px;
+    height: 20px;
 }
 
 .qbtdright {
-	height: 20px;
 	background-image: url(vline.gif);
 	background-repeat: repeat-y;
+    height: 20px;
 	align: right;
 }