Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mutable arguments and unused local variables. Style cleanup. #911

Closed
wants to merge 1 commit into from

Conversation

howtri
Copy link

@howtri howtri commented Dec 1, 2022

Fixes:

  • Remove mutable arguments
  • Remove unused arguments
  • Remove unnecessary parenthesis
  • Make whitespace for docstrings consistent
  • Mark static methods with the staticmethod decorator

@howtri howtri marked this pull request as ready for review December 1, 2022 02:58
Copy link
Member

@stephanebruckert stephanebruckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

happy to merge once feedback is applied :)

@@ -730,7 +715,6 @@ def user_playlist(self, user, playlist_id=None, fields=None, market=None):

def user_playlist_tracks(
self,
user=None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to maintain backward-compatibility you can't change the signature of the methods. These methods are deprecated anyway (see DeprecationWarning just below) and have new up-to-date methods.

@stephanebruckert
Copy link
Member

Closing as this is mostly backward incompatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants