Dark mode seems broken? Black background does not match canvas

[jens-markussen]

Investigate and fix it really a problem exists

https://plan4hub.github.io/yoda/yoda-time-stats.html?owner=plan4hub&repolist=yoda-demo,yoda-demo2&labelsplit=^S[1-4]%20-%20|^prio:%20(.*)&draw=true&dark=true

[jens-markussen]

Very very strangely, the problem does not occur when running against the Yoda files served locally. Does the publishing to GitHub Pages somehow mess up something?

[jens-markussen]

The background is rendered using the following code. How can that possibly be different from page being served locally and using GitHub pages? Very very strange.

	Chart.register({
		id: "yoda-background",
		beforeDraw: function (c) {
			var ctx = c.ctx;
			ctx.fillStyle = getColor('htmlBackground');
			ctx.fillRect(0, 0, c.canvas.width, c.canvas.height);
		}
	});

[jens-markussen]

chartjs documentation https://www.chartjs.org/docs/latest/developers/plugins.html

shows an example which is slightly different for doing the same thing. Maybe worth checking:

const plugin = {
    id: 'custom_canvas_background_color',
    beforeDraw: (chart, args, options) => {
        const {ctx} = chart;
        ctx.save();
        ctx.globalCompositeOperation = 'destination-over';
        ctx.fillStyle = options.color;
        ctx.fillRect(0, 0, chart.width, chart.height);
        ctx.restore();
    },
    defaults: {
        color: 'lightGreen'
    }
}

[jens-markussen]

Fixed. See commit above.