Zero out time in GTFS date string conversions #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid local timezone issues when converting GTFS date strings to/from JS dates by zeroing out the HH:MM:SS portion of the date in
getDateFromGTFSString
. This forces the date object to be created with respect to the machine's local timezone. Prior to this change, thetoGTFSDate
test would fail when running on a machine in EDT, since the date object for20190604
would become20190603
due to the time offset.Specific changes:
toGTFSDate
and corresponding spec file togtfsDateUtils
getDateFromGTFSString
to an external function ingtfsDateUtils
getDateFromGTFSString