Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FindNextHashes() behavior different when no branchpoint is found #2582

Closed
greymistcube opened this issue Nov 26, 2022 · 0 comments
Closed

Make FindNextHashes() behavior different when no branchpoint is found #2582

greymistcube opened this issue Nov 26, 2022 · 0 comments
Assignees
@greymistcube
Labels
api Related to user-facing APIs

Comments

@greymistcube
Copy link
Contributor

Related to #2581.

When the method fails to find a branchpoint between itself and the given BlockLocator object, it simply "assumes" that the branchpoint should be the genesis. This means, this method does not differentiate a case between a valid BlockLocator object with actual genesis branchpoint and some arbitrary/invalid BlockLocator.

If we dig a little deeper, this is due to underlying assumptions, or lack there of, on BlockLocator objects and possible/allowed states for BlockChain<T>. I'll be making a separate issue on this shortly.
@greymistcube greymistcube self-assigned this Nov 26, 2022
@greymistcube greymistcube added the api Related to user-facing APIs label Nov 26, 2022
@greymistcube greymistcube mentioned this issue Nov 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greymistcube greymistcube

Labels
api Related to user-facing APIs
Projects
Blockchain/Libplanet
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@greymistcube