Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate application layer interpretation and storage model scheme. #3571

Open
greymistcube opened this issue Dec 26, 2023 · 0 comments
Open

Comments

@greymistcube
Copy link
Contributor

greymistcube commented Dec 26, 2023

As I have mentioned in #3570, IAccount still has too many responsibilities. This is due to many reasons, one of which is having application layer logic seeping into IAccount interface. I suggest having a middle layer such as IRawAccount to separate the two. We can try to extract Currency/FungibleAssetValue handling altogether by removing Mint()/Burn()/Transfer() from IAccount, but I think this can come later after the layers are separated (and would be actually rather hard as everything is so strongly coupled). I'd also note that cost of maintenance anything related to IAccount is exceptionally high due to lack of pure libplanet side model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant