Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SerializationInfoExtensions #3623

Open
greymistcube opened this issue Jan 22, 2024 · 1 comment
Open

Remove SerializationInfoExtensions #3623

greymistcube opened this issue Jan 22, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@greymistcube
Copy link
Contributor

Two reasons:

  • Without proper documentation, its exact behavior is not intuitive.
  • Doesn't seem to provide much convenience.

All in all, I think the net effect is negative to the whole project. 馃檮

@s2quake
Copy link
Contributor

s2quake commented Apr 15, 2024

These extension methods are often used in serialization, service providers, etc. I think it's better to not use extension methods than to use them, even if it's inconvenient. But I think it depends on the person who uses it, and since there is quite a bit of code that is used now, it would be nice to see if there is a better way to do it than to get rid of it :)
Alternatively, splitting an assembly like dataset.extensions could be another way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants