Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mining should stopped when the chain's tip is changed #460

Closed
longfin opened this issue Aug 26, 2019 · 0 comments · Fixed by #517

Comments

@longfin
Copy link
Member

commented Aug 26, 2019

The current BlockChain<T>.MineBlock() doesn't stop mining when the chain's tip was changed by accepting a block from other miners. at this time, the mined block has the same index as a received block, so it always will fail to append.

To prevent this scenario, BlockChain<T>.MineBlock() should stop when its tip was changed.

@longfin longfin changed the title Stop mining when the chains' tip was changed Stop mining when the chain's tip was changed Aug 26, 2019
@dahlia dahlia changed the title Stop mining when the chain's tip was changed Mining should stopped when the chain's tip is changed Aug 27, 2019
@limebell limebell self-assigned this Sep 17, 2019
@dahlia dahlia closed this in #517 Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.