Fix embedding url broke equality

service/domain/relay_address.go

@@ -10,7 +10,6 @@ import (
 
 type RelayAddress struct {
 	original string
-	parsed   *url.URL
 }
 
 func NewRelayAddress(s string) (RelayAddress, error) {
@@ -28,7 +27,6 @@ func NewRelayAddress(s string) (RelayAddress, error) {
 
 	return RelayAddress{
 		original: s,
-		parsed:   u,
 	}, nil
 }
 
@@ -45,20 +43,22 @@ func NewRelayAddressFromMaybeAddress(maybe MaybeRelayAddress) (RelayAddress, err
 }
 
 func (r RelayAddress) IsLoopbackOrPrivate() bool {
-	hostWithoutPort, err := r.getHostWithoutPort()
-	if err != nil {
-		return false
-	}
+	hostWithoutPort := r.getHostWithoutPort()
 	ip := net.ParseIP(hostWithoutPort)
 	return ip.IsLoopback() || ip.IsPrivate()
 }
 
-func (r RelayAddress) getHostWithoutPort() (string, error) {
-	hostWithoutPort, _, err := net.SplitHostPort(r.parsed.Host)
+func (r RelayAddress) getHostWithoutPort() string {
+	u, err := url.Parse(r.original)
+	if err != nil {
+		panic(err) // checked in constructor
+	}
+
+	hostWithoutPort, _, err := net.SplitHostPort(u.Host)
 	if err != nil {
-		return r.parsed.Host, nil
+		return u.Host
 	}
-	return hostWithoutPort, nil
+	return hostWithoutPort
 }
 
 func (r RelayAddress) String() string {

service/domain/relay_address_test.go

@@ -140,3 +140,11 @@ func TestRelayAddress_IsLocal(t *testing.T) {
 		})
 	}
 }
+
+func TestRelayAddress_Compare(t *testing.T) {
+	a := MustNewRelayAddress("wss://example1.com")
+	b := MustNewRelayAddress("wss://example1.com")
+	c := MustNewRelayAddress("wss://example2.com")
+	require.True(t, a == b)
+	require.True(t, a != c)
+}