Clean up unecessary subscriptions in PagedRelaySubscription #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindsq
requested changes
May 30, 2024
| } | ||
| } | ||
|
|
||
| subscriptionsToRemove.forEach { subscription in |
There was a problem hiding this comment.
I really like when the solution involves using the right data structure. Given that we are already switching to a Set, how about making subscriptionsToRemove a Set of IDs, so that this line I'm commenting can be just pagedSubscriptionIDs.subtract(subscriptionsToRemove)?
martindsq
approved these changes
Jun 4, 2024
mplorentz
deleted the
clean-up-pagedrelaysubscription-pagedsubscriptionids
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
This was something I noticed and fixed while debugging #1192, but I put it in a separate PR.
Description
We weren't clearing out old subscriptions from the PagedRelaySubscription.pagedSubscriptionID array. The actual websocket subscriptions were being closed, but we were keeping references to the
RelaySubscriptionobjects around unnecessarily. It wasn't hurting anything necessarily but this cleans them up.How to test
You can put
Log.debug("pagedSubscriptionIDs count: \(pagedSubscriptionIDs.count)")at the end of thePagedRelaySubscription.loadMore()function before this PR and watch the number climb the more you scroll the home feed. After it should remain equal to the number of relays you have in your relay list.