Add feature flag and unit test for new media display #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindsq
reviewed
Jun 4, 2024
martindsq
reviewed
Jun 4, 2024
mplorentz
reviewed
Jun 4, 2024
martindsq
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#1176
Description
Adds a feature flag for enabling the new media display which is not yet implemented. Establishes a pattern for using feature flags in the app. Adds a test to demonstrate how feature flags can be used and configured differently for testing and production.
How to test
Additionally, run the unit tests to make sure the new one passes.
Video
Here's how you can toggle the flag on and off. Only available in DEBUG builds.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-04.at.15.00.12.mp4