-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover screen in SwiftUI #1082
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really nice. I left a few comments. I found myself wishing for more SwiftUIPreviews. I know we don't have a great way to add preview data to the FakeBot. Maybe we need PreviewBot that loads Feed_big.sqlite or something. But that's probably a task for the future.
Thanks for looking at this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I see your point about changing BotRepository to just be a Bot. Let's try to prioritize that after the retreat.
Closes #587 and #1066
Bonus: