Fix legacy gossip #877
Merged
Fix legacy gossip #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martindsq
approved these changes
Sep 30, 2022
mplorentz
added a commit
that referenced
this pull request
Oct 3, 2022
…d-restore"" This reverts commit d284e27.
This was referenced Oct 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for #847. It makes three changes:
joinedPlanetarySystemoption is false. This fixes the flow where you imported your key into Planetary. When importing a key we automatically setjoinedPlanetarySystemtofalseto prevent auto-publishing of pub messages and forking your feed. However if you have no peers on your local network you have no one to download your own feed from. This should be a temporary fix until we can at least implement Offer to connect to Planetary pubs after key restore #874. Really we need to redo our whole imported key flow.