Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type to posthog events to separate bot from user actions #903

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

rabble
Copy link
Contributor

@rabble rabble commented Oct 10, 2022

In posthog there are event types, but you can't filter by them. So this PR adds a type when it's a did_ action, which is background / bot things, and a 'user' type when it's something else. This should help us see just user driven actions in posthog.

@rabble rabble requested a review from martindsq October 10, 2022 22:51
@rabble rabble added tech A label for technical debt or technology upgrades. small Small estimated effort labels Oct 10, 2022
@mplorentz mplorentz added the Skip-Changelog Signals the Check Changelog CI job that it doesn't need to check this PR. label Oct 17, 2022
Copy link
Member

@mplorentz mplorentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. It's a little hacky, but it will let us actually use the "User Paths" reports in PostHog, which will be really helpful.

I pushed a commit to fix the Codacy issues.

@rabble rabble merged commit 2f1cc05 into main Oct 24, 2022
@rabble rabble deleted the posthog_event_types branch October 24, 2022 19:57
rabble added a commit that referenced this pull request Oct 29, 2022
rabble added a commit that referenced this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip-Changelog Signals the Check Changelog CI job that it doesn't need to check this PR. small Small estimated effort tech A label for technical debt or technology upgrades.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants