Multithread db #915
Merged
Multithread db #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, these unit tests passed locally for me. I will look into them today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#884 This updates
ViewDatabaseto use multiple database connections. Sqlite.swift closes connections when a reference to them goes out of scope. This means I could basically just replacegetOpenDB()function that used to return the one shared connection withcheckoutConnection()that opens a new connection each time it is called.It would probably be more performant to have some kind of connection pool of a finite size. Then connections would just be reused. But this was easier and speeds up our database a lot, so I'm doing it the simple way for now.