Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call bot on main thread #925

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Don't call bot on main thread #925

merged 3 commits into from
Oct 21, 2022

Conversation

mplorentz
Copy link
Member

@mplorentz mplorentz commented Oct 18, 2022

#865 I found the issue with the freeze after launch this morning so I coded up a quick fix. The fix is to not call ssbDisconnectAllPeers when we receive a memory warning in AppController. Or at least don’t call it on the main thread.

@wsarles wsarles self-requested a review October 20, 2022 13:42
Copy link
Contributor

@wsarles wsarles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@martindsq
Copy link
Member

Fixes #865

@martindsq martindsq linked an issue Oct 21, 2022 that may be closed by this pull request
@martindsq martindsq merged commit d5aeff0 into main Oct 21, 2022
@martindsq martindsq deleted the fix-freeze-on-memory-warning branch October 21, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI lockup after starting the app
3 participants