Multi wallet & app design R3 #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use SynclayoutUtil to manage all sync layout changes thereby cleaning up overview fragment. - Complete sync layout
- Accounts ReclyerView - Added "Add a wallet" button - Use Toolbar for MainActivity's top bar - Overivew Page add button to syncing layout to cancel sync implement multi wallet fetch header process
- added collapse icon
- set ripple for every background - change wallets collaps menu - increase wallet menu option ripple padding
- also added dialog to prompt spending passphrase
- added custom checkbox and also defined all font styles of source sans pro in one file - added showError function to Snackbar
- custom info dialog - added account picker bottom sheet dialog
- Remove bottom sheet extra top padding - Fix create and restore button layout and ripple
- Currency conversion and switch between dcr and usd - Custom spinners to select account - Confirm transaction bottom sheet
- Changed transaction details dialog to a bottomsheet. - added collapsible layout with extra transaction details. - added custom dropdown for transaction input and output items.
- Create & remove security pin. - Enter security pin at startup.
This adds a preference item under "Startup PIN/Password" category.
Custom password input was added everywhere as it wasn't used before. Custom passcode input was also used in unlock wallet dialog.
This was referenced Dec 6, 2019
dreacot
reviewed
Dec 16, 2019
There was a problem hiding this comment.
- Wallet name doesn't trim spaces.
When creating or renaming a wallet, the extra white-space isn't trimmed before saving, giving the wallet name unnecessary blank spaces as seen in the picture
Version: testnet 2019-12-14
Android Version: 9.0
Phone Model: Samsung Galaxy A7
-
Push notifications doesn't play sound and doesn't vibrate.
Two scenarios
i. When you receive DCR from another user with app in background, you get push notification without sound or vibration, even though it's set to do so
ii.When you transfer DCR between your wallets, you get push notifications, but without sound or vibration
Version: testnet 2019-12-14
Android Version: 9.0
Phone Model: Samsung Galaxy A7
- beep new blocks - trim account name before creating/renaming account - increase tx notification importance from low to high. notifications with low importance from android 8.0, are delivered silently and causes a bug with the app notifications settings as sound and vibration are not working. - clear transaction list if a tx filter with zero matches is selected. - change toolbar title left-padding to 8dp for toolbars having 16dp left padding.
This was referenced Dec 20, 2019
This was referenced Sep 21, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements Multi Wallet (planetdecred/dcrlibwallet#57), rewrites most of the Java code in Kotlin and the entire user interface was changed. MultiWallet allows running more than one wallet concurrently. All wallets are opened at startup using the same public passphrase(to avoid prompting the user for each wallet's public passphrase).
These are screenshots explaining the multi-wallet features and also shows the new user interface.
Account Selector
