Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overview UI and implementation of account mixer #727

Merged
merged 39 commits into from
May 17, 2021

Conversation

macsleven
Copy link
Contributor

@macsleven macsleven commented Nov 8, 2020

Screenshot 2020-12-30 at 16 36 17 Screenshot 2021-02-04 at 23 57 52 Screenshot 2021-02-05 at 00 26 36
Screenshot 2021-02-05 at 00 11 45

Screenshot 2020-12-30 at 16 37 46 Screenshot 2020-12-30 at 17 05 47 Screenshot 2020-12-30 at 17 12 39
Screenshot 2020-12-30 at 21 39 32
Screenshot 2020-12-31 at 08 02 07 Screenshot 2020-12-31 at 08 03 25

@beansgum beansgum added this to In progress in dcrios board May 12, 2021
@beansgum beansgum marked this pull request as ready for review May 14, 2021 06:23
Copy link
Contributor

@dreacot dreacot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While trying the send to account, the unmixed account doesn't show
Screenshot from 2021-05-12 02-17-40

@dreacot
Copy link
Contributor

dreacot commented May 14, 2021

I get a yellow icon for transfers, it should be gray

Screenshot from 2021-05-12 02-24-46

@dreacot
Copy link
Contributor

dreacot commented May 14, 2021

The danger zone should be removed
Screenshot from 2021-05-12 02-34-29

@dreacot
Copy link
Contributor

dreacot commented May 14, 2021

DCR should be suffixed after the balances

Screenshot from 2021-05-12 02-44-23

after the 2 digits after the decimal, the rest digits should be a lighter grey color as seen below
cbfd2298-4e84-45a7-88eb-c5e2d8f02dd3

@dreacot
Copy link
Contributor

dreacot commented May 14, 2021

  1. The number of mixers running should be displayed to user
  2. Under the wallet name, what should be displayed should be the "Unmixed balance" and not the "Mixed balance"
  3. Clicking the arrow should take you to the wallets page

see a reference below

@dreacot
Copy link
Contributor

dreacot commented May 14, 2021

The "Privacy is here" card should disappear after setting up the mixer
Screenshot from 2021-05-12 03-01-25

@dreacot
Copy link
Contributor

dreacot commented May 14, 2021

The info dialog on the mixer page isn't properly formatted

see reference below

@dreacot
Copy link
Contributor

dreacot commented May 14, 2021

The title of some mixer settings have been changed

see reference below(also note to capitalize when necessary)

@dreacot
Copy link
Contributor

dreacot commented May 14, 2021

The unmixed balance shows an exponential value when the mixer completes
Screenshot from 2021-05-12 16-29-10

Copy link
Contributor

@beansgum beansgum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This message should be "Set up StakeShuffle here" and it should only be shown once, currently it shows whenever I open the wallets page.

2. This dialog returns to the overview page after refreshing, it should not return again for the current app run once dismissed.

3. Overview page is still showing "Privacy is here" card after I just set up privacy. 4. Capitalise error message.

5. Capitalise "Mixer is running" and add "DCR" to the unmixed balance amount.

6. Mixed transactions should be labeled as 'Mix', modifications should be made in the transaction row and transaction details dialog title. Also, remove the double negative sign from the amount and the amount should be the mix denomination(`mix_denom` in the transaction json).

@beansgum
Copy link
Contributor

The remaining fixes will be sent as separate prs.

@macsleven macsleven merged commit e40f54b into planetdecred:master May 17, 2021
dcrios board automation moved this from In progress to Done May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
dcrios board
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants