Add password input delay to slow down brute force attacks #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ideally brute force protections should be at the logical layer. Perhaps increase number of derivation iterations based on phone specs ? |
|
Yeah, we could do that but for now, we're leaving the number of derivation iterations to dcrwallet's default as it's not currently possible to change the number outside dcrwallet and we're currently investigating how the current derivation iterations could be increasing the app's CPU/memory usage. |
JustinBeBoy
previously requested changes
May 12, 2021
Decred Wallet/Features/Custom Dialogs/SimpleTextInputDialog.swift
Outdated
Show resolved
Hide resolved
Decred Wallet/Features/Security/SecurityCodeRequestBaseViewController.swift
Show resolved
Hide resolved
dreacot
reviewed
May 16, 2021
| @@ -50,6 +50,9 @@ class SecurityCodeRequestBaseViewController: UIViewController { | |||
| func hideError() { | |||
| self.isInErrorState = false | |||
| } | |||
|
|
|||
| func showPassphraseError(text: String) { | |||
There was a problem hiding this comment.
@C-ollins nothing seems to be done inside this function
There was a problem hiding this comment.
The function is implemented in subclasses.
https://github.com/planetdecred/dcrios/pull/749/files#diff-a03f6b93d054b97dd40df7affd98091d143090b230b94b6f916541ab3801683bR224
dreacot
approved these changes
May 17, 2021
macsleven
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a 5 seconds delay after every even password trial and 2 seconds delay for otherwise in an attempt to slow down a brute force attack.
Closes #740
(Password & keyboard are censored but the delay is visible)