Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

send page: indicate mixed transaction change destination account #807

Merged
merged 4 commits into from
Jun 19, 2021
Merged

send page: indicate mixed transaction change destination account #807

merged 4 commits into from
Jun 19, 2021

Conversation

macsleven
Copy link
Contributor

@macsleven macsleven commented Jun 15, 2021 •
edited
Loading

Requires planetdecred/dcrlibwallet#199

  • make send max button blue when active

Sending w/ change
Screenshot 2021-06-17 at 10 19 17

Sending w/o change
Screenshot 2021-06-17 at 10 18 52

Sending from other accounts(mix change enabled)
Screenshot 2021-06-17 at 10 21 56

Privacy settings
Screenshot 2021-06-17 at 10 19 50

@macsleven macsleven marked this pull request as ready for review June 17, 2021 09:15
beansgum
beansgum suggested changes Jun 17, 2021
View reviewed changes
Copy link
Contributor

@beansgum beansgum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tx estimation is not updated if source account is changed. I have mix change disabled but the change label is still showing after switching to an unmixed account.

  • Change label should not be shown if destination account is unmixed.

Decred Wallet/Features/Overview/OverviewViewController.swift Outdated Show resolved Hide resolved
@beansgum beansgum merged commit 010ab1e into planetdecred:master Jun 19, 2021
@dreacot dreacot mentioned this pull request Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beansgum beansgum beansgum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macsleven @beansgum