Send custom inputs #165
Merged
Send custom inputs #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(*Wallet).UnspentOutputs method
* Adds (*TxAuthor).AddChangeDestination * Adds (*TxAuthor).UpdateChangeDestination * Adds (*TxAuthor).RemoveChangeDestination
beansgum
suggested changes
Oct 27, 2020
beansgum
suggested changes
Oct 31, 2020
* Refactor (*TxAuthor).UseInputs find utxo by txn outpoint * Adds (*TxAuthor).newUnsignedTxUTXO * Change UnspentOutput.Address to UnspentOutput.Addresses
song50119
force-pushed
the
send-custom-inputs
branch
from
728a131
to
39ec793
Compare
beansgum
suggested changes
Nov 3, 2020
beansgum
suggested changes
Nov 5, 2020
utxo.go
Outdated
|
|
||
| for _, destination := range txDestinations { | ||
| // validate the amount to send to this destination address | ||
| if !destination.SendMax && (destination.AtomAmount <= 0 || destination.AtomAmount > dcrutil.MaxAmount) { |
There was a problem hiding this comment.
On the mobile or wallet if developer is forget to check errors at AddSendDestination or UpdateSendDestination, we should validate again here, right?
* Change (*TxAuthor).changeDestinations slice to single changeDestination * Adds (*TxAuthor).validateAmount && git push origin send-custom-inputs
beansgum
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is continues process on this branch for UTXO
txhelper/internal/txsizes/size.gotxhelper/unsignedtx.gotxhelper/types.gofiles since it isn't necessaryTransactionDestinationtype from types.go