Send Page amount USD. #152
Conversation
|
The amount-usd feature doesn't work. The currency conversion feature isn't just to show a user DCR equivalent in dollars but to also allow the user input an amount in dollars and have its DCR equivalent sent. Currently, it doesn't do that. |
|
The position of the conversion button and values look off, we should be able to make it look just like the mobile. Kindly have a look at the related issue for the mobile mockup.
|
Resolved.
|
ui/send_page.go
Outdated
| pg.activeTotalAmount = dcrutil.Amount(amountAtoms).String() | ||
| pg.inactiveTotalAmount = totalAmountUSDTostring | ||
| pg.activeTransactionFeeValue = dcrutil.Amount(txFee).String() | ||
| pg.inactiveTransactionFeeValue = fmt.Sprintf("(%f USD)", txFeeValueUSD) | ||
| pg.activeTotalCostValue = dcrutil.Amount(totalCostDCR).String() | ||
| pg.inactiveTotalCostValue = fmt.Sprintf("(%s USD)", strconv.FormatFloat(totalAmountUSD+txFeeValueUSD, 'f', 7, 64)) |
There was a problem hiding this comment.
This looks repeated. To make it cleaner, you can create a data type for it. For each case, assign the respective data properties their respective methods and pass that to a single method that initiates those values to the SendPage properties.
Also, all that would be cleaner if they were in a separate method.
ui/send_page.go
Outdated
| return amountAtoms | ||
| } | ||
|
|
||
| func (pg *SendPage) setUSDValues(usdExchangeRate, inputAmount float64, totalCostDCR, txFee, amountAtoms int64) { |
There was a problem hiding this comment.
make this a data type and pass a single argument to the Set method.
ui/send_page.go
Outdated
| pg.activeTotalAmount = totalAmountUSDTostring | ||
| pg.inactiveTotalAmount = dcrutil.Amount(amountAtoms).String() | ||
| pg.activeTransactionFeeValue = fmt.Sprintf("%f USD", txFeeValueUSD) | ||
| pg.inactiveTransactionFeeValue = fmt.Sprintf("(%s)", dcrutil.Amount(txFee).String()) | ||
| pg.activeTotalCostValue = fmt.Sprintf("%s USD", strconv.FormatFloat(inputAmount+txFeeValueUSD, 'f', 7, 64)) | ||
| pg.inactiveTotalCostValue = fmt.Sprintf("(%s )", dcrutil.Amount(totalCostDCR).String()) |
There was a problem hiding this comment.
you only need one method to set these.
ui/send_page.go
Outdated
| pg.activeTotalAmount = dcrutil.Amount(amountAtoms).String() | ||
| pg.inactiveTotalAmount = totalAmountUSDTostring | ||
| pg.activeTransactionFeeValue = dcrutil.Amount(txFee).String() | ||
| pg.inactiveTransactionFeeValue = fmt.Sprintf("(%f USD)", txFeeValueUSD) | ||
| pg.activeTotalCostValue = dcrutil.Amount(totalCostDCR).String() | ||
| pg.inactiveTotalCostValue = fmt.Sprintf("(%s USD)", strconv.FormatFloat(totalAmountUSD+txFeeValueUSD, 'f', 7, 64)) |
There was a problem hiding this comment.
you only need one method to set these.
ui/send_page.go
Outdated
| func (pg *SendPage) updateDefaultValues(totalCostDCR, txFee, amountAtoms int64, noExchangeText string) { | ||
| pg.activeTotalAmount = dcrutil.Amount(amountAtoms).String() | ||
| pg.inactiveTotalAmount = noExchangeText | ||
| pg.activeTransactionFeeValue = dcrutil.Amount(txFee).String() | ||
| pg.inactiveTransactionFeeValue = "" | ||
| pg.activeTotalCostValue = dcrutil.Amount(totalCostDCR).String() | ||
| pg.inactiveTotalCostValue = "" | ||
| } |
There was a problem hiding this comment.
this is the only method you need to set the data. And it only really needs to accept one argument.
remove data struct
initialize exchange call on send page load split switch code to multi func
fix issue with repeated print to terminal
* add default value without exchange * add currency change button * remove imported account * initialize exchange call on send page load
Resolves
Issue #142
What's new
This PR adds the send amount USD equivalence for all transactions fields to the send Page.
Relevant screenshots or logs