Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ui restore page #386

Merged

Conversation

JustinBeBoy
Copy link
Contributor

@JustinBeBoy JustinBeBoy commented Apr 27, 2021

Resolve #376

  • Update layout in restore seed page
  • Custom UI Editor
  • Custom UI dropdown
  • Custom space vertical

@JustinBeBoy JustinBeBoy force-pushed the update_restore_wallet_page branch 2 times, most recently from 70414d6 to 962dea7 Compare April 28, 2021 16:30
@JustinBeBoy JustinBeBoy marked this pull request as ready for review April 28, 2021 16:30
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The restore button is supposed to grayed out and inactive when the inputs are still empty.
image

Also, kindly pay attention to the dimensions on the mockup so that your design aligns accordingly.

ui/decredmaterial/restoreeditor.go Outdated Show resolved Hide resolved
ui/decredmaterial/restoreeditor.go Outdated Show resolved Hide resolved
ui/decredmaterial/restoreeditor.go Outdated Show resolved Hide resolved
ui/create_restore_page.go Outdated Show resolved Hide resolved
ui/create_restore_page.go Outdated Show resolved Hide resolved
ui/create_restore_page.go Outdated Show resolved Hide resolved
ui/create_restore_page.go Outdated Show resolved Hide resolved
ui/create_restore_page.go Outdated Show resolved Hide resolved
ui/create_restore_page.go Outdated Show resolved Hide resolved
ui/create_restore_page.go Show resolved Hide resolved
@oshorefueled
Copy link
Contributor

oshorefueled commented May 2, 2021

Clicking the "import an existing wallet" go straight to the restore page and not the wallet/restore page first. The page is no longer needed.
Screenshot 2021-05-02 at 17 25 22

ui/decredmaterial/verticalline.go Outdated Show resolved Hide resolved
@JustinBeBoy JustinBeBoy force-pushed the update_restore_wallet_page branch 2 times, most recently from e56baad to fabf19e Compare May 4, 2021 15:17
ui/create_restore_page.go Outdated Show resolved Hide resolved
ui/decredmaterial/restoreeditor.go Outdated Show resolved Hide resolved
ui/decredmaterial/line.go Outdated Show resolved Hide resolved
ui/decredmaterial/line.go Outdated Show resolved Hide resolved
@JustinBeBoy JustinBeBoy force-pushed the update_restore_wallet_page branch 2 times, most recently from e796864 to cae95c4 Compare May 12, 2021 13:56
ui/decredmaterial/editor.go Outdated Show resolved Hide resolved
- custom card layout
- custom restore button
- custom seed dropdown
- update list layout
- add action restore
  - remove commented code
  - change dimensions between header and seed phase
  - change dimensions between card section content and card header
  - change color of restore button when inactive & active.
 - Add vertical option to line.go
 - Fix Typo
 - Move restoreeditor to editor
@oshorefueled oshorefueled dismissed Sirmorrison’s stale review May 12, 2021 15:03

requested changes have been resolved

@oshorefueled oshorefueled merged commit 05aae74 into planetdecred:master May 12, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
* Create the base layout for the restore page
- add a custom card and restore button layout.

* Add custom editor for inputting seed
- add dropdown menu to select a seed from a list of seed suggestions
- add wallet restore functionality to the updated UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add restore page
3 participants