Replace explicit DPI conversions with standard unit type #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beansgum
suggested changes
May 18, 2021
There was a problem hiding this comment.
There are other places where this change is needed.
https://github.com/planetdecred/godcr/blob/master/ui/tickets_page.go#L531
https://github.com/planetdecred/godcr/blob/master/ui/wallet_page.go#L378
- Change the type of width to unit.Value
tuhalang
force-pushed
the
replace_explicit_dpi
branch
from
876c27a
to
f3a0654
Compare
beansgum
approved these changes
May 18, 2021
oshorefueled
approved these changes
May 20, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
May 29, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #416