Add main page #459
Merged
Add main page #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- setup topbar and navigation layout in main page - calculate and display total balance in main page - handle nav items and and page history in main page
|
oshorefueled
suggested changes
Jun 4, 2021
ui/window.go
Outdated
Comment on lines
112
to
115
| func (win *Window) changePage(page string) { | ||
| win.pages[win.current].onClose() | ||
| win.current = page | ||
| _ = page | ||
| win.refresh() | ||
| } |
There was a problem hiding this comment.
This method doesn't seem to be doing anything, it can be removed. The win.refresh() method isn't needed as well. Each page can handle invalidating the page by calling op.InvalidateOp. The changePageAndRefresh doesn't seem to be doing anything either.
Comment on lines
+281
to
+284
| // if *pg.refreshPage { | ||
| // common.refreshWindow() | ||
| // *pg.refreshPage = false | ||
| // } |
There was a problem hiding this comment.
This can be deleted if it's not needed.
|
The top bar doesn't seem to be updated until I restart the app. I changed the currency conversion option in the settings page and it doesn't get displayed on the top bar until I restart the app. |
oshorefueled
approved these changes
Jun 5, 2021
tuhalang
pushed a commit
to tuhalang/godcr
that referenced
this pull request
Jun 5, 2021
* use pageCommmon a pointer across all pages * Add main page - setup topbar and navigation layout in main page - calculate and display total balance in main page - handle nav items and and page history in main page * Remove redundant use of common.Layout function - the common.Layout included the side nav and top bar which was called by every page to render its layout. This removes the general Layout method forcing pages to return only its own layout to the main page.
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* use pageCommmon a pointer across all pages * Add main page - setup topbar and navigation layout in main page - calculate and display total balance in main page - handle nav items and and page history in main page * Remove redundant use of common.Layout function - the common.Layout included the side nav and top bar which was called by every page to render its layout. This removes the general Layout method forcing pages to return only its own layout to the main page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds a new page,
MainPage, and its job is to manage the app toolbar, navigation bar, and back stack history of other pages and it also moves the independent management of the page navigation from the pages toMainPage.