Cleanup proposals page #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
beansgum
commented
Jul 2, 2021
beansgum
commented
- Use clickable list to layout tabs and proposals list.
- Remove redundant tabs structs.
- Load proposals directly when dcrlibwallet.
- Register for politeia sync notifications and reload proposals when synced.
- Add list divider to clickable list and apply to proposals list.
- Pass proposal data to proposal details page.
- Remove global proposal variables.
- Use clickable list to layout tabs and proposals list - Remove redundant tabs structs - Load proposals directly from dcrlibwallet - Register for politeia sync notifications and reload proposals when synced - Add list divider and click highlight options to clickable list
- Remove highlight option from clickable highlight - Remove global proposal variables
dreacot
previously approved these changes
Jul 5, 2021
oshorefueled
suggested changes
Jul 8, 2021
Co-authored-by: Osho Emmanuel <oshoklinsmann@gmail.com>
oshorefueled
approved these changes
Jul 8, 2021
dreacot
approved these changes
Jul 8, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* Cleanup proposals page - Use clickable list to layout tabs and proposals list - Remove redundant tabs structs - Load proposals directly from dcrlibwallet - Register for politeia sync notifications and reload proposals when synced - Add list divider and click highlight options to clickable list * Pass proposal data to proposal details page - Remove highlight option from clickable highlight - Remove global proposal variables * Fix requested changes Co-authored-by: Osho Emmanuel <oshoklinsmann@gmail.com> Co-authored-by: Osho Emmanuel <oshoklinsmann@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.