cleanup markdown tables #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beansgum
suggested changes
Jul 20, 2021
There was a problem hiding this comment.
- Line break does not work. Two spaces followed by a new line is supposed to break to the next line.
First line
Second line
third line
- Strikethrough doesn't work either.
~~The world is flat.~~Expected:
The world is flat.
- Ruler does not work.
before ruler
---
after rulerExpected:
before ruler
after ruler
- The app crashes when trying to render this table. https://pastebin.com/YvymiZNb
| Syntax | Description |
| ----------- | ----------- |
| Header | Title |
| Paragraph | Text |- Emphasis does not work
Emphasis, aka italics, with *asterisks* or _underscores_.
Expected:
Emphasis, aka italics, with asterisks or underscores.
- Trying to use bold causes all the text to be bold and double underscores breaks to the next line.
Emphasis, aka italics, with *asterisks* or _underscores_.
Strong emphasis, aka bold, with **asterisks** or __underscores__.Expected:
Emphasis, aka italics, with asterisks or underscores.
Strong emphasis, aka bold, with asterisks or underscores.
ugwueze-dev
force-pushed
the
markdown-tables
branch
from
6bb088e
to
52a3bad
Compare
beansgum
previously requested changes
Aug 16, 2021
beansgum
added a commit
to beansgum/godcr
that referenced
this pull request
Aug 17, 2021
* privacy: add introduction card and popup message * Implement privacy page design - add privacy introduction card to overview page - add 'new' badger on privacy list items under wallet options - add SetupPrivacy page - update list cards design to include divider lines and higher radius * complete account mixer page design and functionality * Add mixer status card to overview page * add 'go to mixer' button in overview page * Multi-wallet mixing status * coin format: add foreground color span * privacy: check account name for conflict before creating privacy accounts * remove unnecessary comments * Fix faint transaction list divider * privacy: add auto and manual setup screens * Remove excess parameters from account spinner and make them class memebers - add account filter to filter out accounts from account picker * privacy: implement manual mixer setup * account picker: add support for showing just one wallet
beansgum
force-pushed
the
markdown-tables
branch
from
42050c2
to
b53e922
Compare
beansgum
force-pushed
the
markdown-tables
branch
from
b53e922
to
23e6ddf
Compare
|
@C-ollins Now that Codemaestro is no longer working on this what is needed? Who should be dealing with it? |
|
This pr is waiting for review. |
dreacot
approved these changes
Sep 16, 2021
|
I am not mistaking, this text here are supposed to be rendered as links right and not what is in the screenshot.
|
|
No those are codeblocks, they’re meant to be rendered as code though we’re not doing syntax highlighting. |
Sirmorrison
approved these changes
Sep 16, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* cleanup markdown tables * correctly render markdown widgets * separate html and markdown renderers * render list items * Render code and code block - Remove clickable links * Reduce H4 text size to 32 * Set text size for all header levels Co-authored-by: Olanrewaju Collins <ocollins444@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the loop of markdown tables by using equal cell widths. It also uses alternating row colors.
It fixes an issue with lists where formatted list content is displayed below It's bullet.