New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LinearLayout #563
Merged
Merged
Add LinearLayout #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinearLayout serves as a wrapper for several gio layout structs and it reduces the amount of code required when applying basic attributes like padding, margin, border, etc to a layout.
Sirmorrison
suggested changes
Aug 18, 2021
Sirmorrison
suggested changes
Aug 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did not add the sample layout code to the test
package for code reference.
ui/decredmaterial/linearlayout.go
Outdated
return layout.Stack{}.Layout(gtx, | ||
layout.Expanded(func(gtx C) D { | ||
ll.applyDimension(>x) | ||
// // draw background and and clip the background to border radius |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// // draw background and and clip the background to border radius | |
// draw background and clip the background to border radius |
Sirmorrison
previously approved these changes
Aug 20, 2021
dreacot
previously approved these changes
Aug 20, 2021
dreacot
approved these changes
Aug 20, 2021
Sirmorrison
approved these changes
Aug 21, 2021
song50119
pushed a commit
to song50119/godcr
that referenced
this pull request
Apr 24, 2022
* Add LinearLayout LinearLayout serves as a wrapper for several gio layout structs and it reduces the amount of code required when applying basic attributes like padding, margin, border, etc to a layout. * Fix lint * Fix typo in comment * Use linear layout in more page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinearLayout serves as a wrapper for several gio layout structs and it reduces the amount of code required when applying basic attributes like padding, margin, border, etc to a layout. The number of lines of code used for the most basic layouts can sometimes look very complex due to the multiple nested functions.
This layout code:
Can be replaced by this using the LinearLayout:
I created an example of LinearLayout here and this is the result: