Add backdrop for dropdown #616
Conversation
- add IsOpen() and CloseDropdown() to dropdown widget
|
@JustinBeBoy This hasn't been implemented in the ticket activity page |
- add backdrop to ticket activity page - fix wallet dropdown icon size and alignment with wallet text
This is now resolved. |
- Remove backdrops in all pages use dropdown - Refactor code in dropdown, transaction page, activity page and list page - Align layout dropdown in pages use it
JustinBeBoy
force-pushed
the
overlay_dropdown
branch
from
fde8fa8
to
8d74ba1
Compare
ui/page/transactions_page.go
Outdated
| return pg.walletDropDown.Layout(gtx, 0) | ||
| }), | ||
| layout.Expanded(func(gtx C) D { | ||
| post := float32(gtx.Constraints.Max.X - 315) |
There was a problem hiding this comment.
rename all occurrence of post to position or pos
I cant reproduce it in computer, can you tell me steps to reproduce it |
|
@Sirmorrison I can't also reproduce the ui bug. |
Let me try from my mac machine it was noticed on windows this is what i get on my macbook transaction page
ticket page
|
ui/page/tickets/activity_page.go
Outdated
| layout.Expanded(func(gtx C) D { | ||
| return pg.walletDropDown.Layout(gtx, 0) | ||
| }), | ||
| layout.Expanded(func(gtx C) D { | ||
| post := float32(gtx.Constraints.Max.X - 150) | ||
| return pg.orderDropDown.Layout(gtx, post) | ||
| }), | ||
| layout.Expanded(func(gtx C) D { | ||
| post := float32(gtx.Constraints.Max.X - 315) | ||
| return pg.ticketTypeDropDown.Layout(gtx, post) |
There was a problem hiding this comment.
So doing troubleshooting, this seems to be where the issue is coming from.
Changing the values as suggested below, give me the screenshots below.
| layout.Expanded(func(gtx C) D { | |
| return pg.walletDropDown.Layout(gtx, 0) | |
| }), | |
| layout.Expanded(func(gtx C) D { | |
| post := float32(gtx.Constraints.Max.X - 150) | |
| return pg.orderDropDown.Layout(gtx, post) | |
| }), | |
| layout.Expanded(func(gtx C) D { | |
| post := float32(gtx.Constraints.Max.X - 315) | |
| return pg.ticketTypeDropDown.Layout(gtx, post) | |
| layout.Expanded(func(gtx C) D { | |
| return pg.walletDropDown.Layout(gtx, 0) | |
| }), | |
| layout.Expanded(func(gtx C) D { | |
| post := float32(gtx.Constraints.Max.X - 450) | |
| return pg.orderDropDown.Layout(gtx, post) | |
| }), | |
| layout.Expanded(func(gtx C) D { | |
| post := float32(gtx.Constraints.Max.X - 300) | |
| return pg.ticketTypeDropDown.Layout(gtx, post) |
I think the issue here has to do with the screen size of the machine. you will need to use gtx.Px() for positioning and scaling.
|
The space between the dropdown is too much... See the red section on the screenshot. |
* custom dropdown backdrop and implement page use * add backdrop to tx and ticket page - add IsOpen() and CloseDropdown() to dropdown widget * fix wallet dropdown not opening bug ticket activity page - add backdrop to ticket activity page - fix wallet dropdown icon size and alignment with wallet text * - Create backdrop for dropdown - Remove backdrops in all pages use dropdown - Refactor code in dropdown, transaction page, activity page and list page - Align layout dropdown in pages use it * fix issue of different screen resolutions * change layout and resolve different resolutions * caculate and change space between dropdown Co-authored-by: sirmorrison <edonomorrison@gmail.com>
This PR resolve #581 with detail: