Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for turning proposal notification on/off #721

Merged
merged 6 commits into from Dec 21, 2021
Merged

Add support for turning proposal notification on/off #721

merged 6 commits into from Dec 21, 2021

Conversation

AdimekweEbuka
Copy link
Contributor

Fix #720

Sirmorrison
Sirmorrison suggested changes Dec 16, 2021
View reviewed changes
ui/page/settings_page.go Outdated Show resolved Hide resolved
ui/page/settings_page.go Outdated Show resolved Hide resolved
ui/page/governance/proposals_page.go Outdated Show resolved Hide resolved
ui/page/governance/proposal_details_page.go Outdated Show resolved Hide resolved
Sirmorrison
Sirmorrison suggested changes Dec 17, 2021
View reviewed changes
ui/page/listeners.go Outdated Show resolved Hide resolved
ui/page/settings_page.go Outdated Show resolved Hide resolved
ui/page/listeners.go Outdated Show resolved Hide resolved
dreacot
dreacot reviewed Dec 17, 2021
View reviewed changes
ui/load/utils.go Outdated Show resolved Hide resolved
Sirmorrison
Sirmorrison suggested changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@Sirmorrison Sirmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn on the proposal notification, exit the settings page to any other page, then go back to the settings, the toggle is turned off.
image

it seems you are not updating the proposals settings on resume.

dreacot
dreacot requested changes Dec 20, 2021
View reviewed changes
ui/page/settings_page.go Outdated Show resolved Hide resolved
@Sirmorrison Sirmorrison merged commit fa9fd96 into planetdecred:master Dec 21, 2021
song50119 pushed a commit to song50119/godcr that referenced this pull request Apr 24, 2022
@AdimekweEbuka
Add support for enabling and disabling proposal notification (planetd…
9fca223 
…ecred#721)

* add support for  enabling and disabling proposal notification 

* move proposal bool to listeners page

* move proposal config key to utils.go

* add underscore key to proposal constant in util.go

* Update proposal setting on resume

* change proposal notification bool variable name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreacot dreacot dreacot approved these changes

@Sirmorrison Sirmorrison Sirmorrison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for turning on and off Propsal notification.
3 participants
@AdimekweEbuka @dreacot @Sirmorrison