Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

localize string variables #906

Merged
merged 15 commits into from Jun 2, 2022
Merged

Conversation

Sirmorrison
Copy link
Contributor

@Sirmorrison Sirmorrison commented Apr 28, 2022

Fix #854

This PR localize string variable on the godcr app.

String localization includes Spanish and French language local which was archived using google translate.

@Sirmorrison Sirmorrison added this to In Progress in godcr board Apr 29, 2022
@Sirmorrison Sirmorrison force-pushed the string_local branch 5 times, most recently from fd05d9a to 4b92a39 Compare May 24, 2022 18:37
@Sirmorrison Sirmorrison marked this pull request as ready for review May 24, 2022 18:38
ui/page/components/utils.go Show resolved Hide resolved
ui/page/governance/proposal_details_page.go Show resolved Hide resolved
ui/page/governance/splash_screen.go Show resolved Hide resolved
ui/page/main_page.go Outdated Show resolved Hide resolved
ui/page/security_tools_page.go Outdated Show resolved Hide resolved
ui/page/staking/auto_ticket_modal.go Outdated Show resolved Hide resolved
ui/page/staking/auto_ticket_modal.go Outdated Show resolved Hide resolved
@dreacot
Copy link
Collaborator

dreacot commented May 26, 2022

proposals aren't showing
Screenshot from 2022-05-26 17-15-44

@dreacot
Copy link
Collaborator

dreacot commented May 26, 2022

The info icon on the governance splash page doesn't work

Copy link
Contributor

@devchoplife devchoplife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

godcr board automation moved this from In Progress to Approved Jun 2, 2022
@dreacot dreacot merged commit a0297f9 into planetdecred:master Jun 2, 2022
godcr board automation moved this from Approved to Done Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
godcr board
  
Done
Development

Successfully merging this pull request may close these issues.

Review that all strings in the app are properly localized for new functionality.
3 participants