Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConvertLabelsToFilterExpr fails silently when multiple labels with same key #107

Closed
dbenque opened this issue Dec 11, 2020 · 0 comments · Fixed by #108
Closed

ConvertLabelsToFilterExpr fails silently when multiple labels with same key #107

dbenque opened this issue Dec 11, 2020 · 0 comments · Fixed by #108

Comments

@dbenque
Copy link
Contributor

dbenque commented Dec 11, 2020

If draino is started with:

        - --node-label=mykey=value1
        - --node-label=mykey=value2

only the second value is taken into account. This is respecting the documentation since multiple --node-label are supposed to work like a AND. But this is failing silently.
@dbenque dbenque mentioned this issue Dec 11, 2020
Merged
jacobstr added a commit that referenced this issue Dec 14, 2020
@jacobstr
Merge pull request #108 from DataDog/david.benque/issue-107
9d39b53 
fail to start if node-label is provided twice with the same key - issue #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fail to start if node-label is provided twice with the same key - issue #107 DataDog/draino
1 participant
@dbenque