Add sorting rules #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschaub
reviewed
Nov 10, 2020
react.js
Outdated
| 'react/jsx-boolean-value': 'error', | ||
| 'react/jsx-key': 'error', | ||
| 'react/jsx-no-duplicate-props': 'error', | ||
| 'react/jsx-no-undef': 'error', | ||
| 'react/jsx-sort-props': 'off', | ||
| 'react/jsx-sort-default-props': 'error', | ||
| 'react/jsx-sort-props': 'error', |
There was a problem hiding this comment.
See also db7a16d. Only pointing out that there are different opinions on this one. I don't have any strongly held opinions on these things as long as they are auto-fixable.
There was a problem hiding this comment.
I just think the more rules we have the less the codebases can differ and the easier it is to switch between them going forward in Brian's and Quinn's idea to have teams less siloed in distinct projects 🤷
There was a problem hiding this comment.
I also understand there are different opinions on this one, at first I kind of disliked the sorting (as overkill), but now that I have gotten used to it it helps to find stuff more easily and read code better
Primajin
force-pushed
the
sort-keys-and-props
branch
from
49d17d3
to
125df47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.