import WebGLTile as TileLayer in front page example #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arne Kepp <git@kepp.net>
|
Hi, @arneke! Thanks for this fix (quite an oversight to have the top example broken). We鈥檙e still trying to decide how painful the sign-off requirement will be. Thanks for conforming. Hope you鈥檙e well. |
|
I'm good, hope you are too. Got an Ext 3.4 / OL 2.12 application to rewrite 馃槄 I edited (my fork) directly on Github and committed with just "import WebGLTile as TileLayer in front page example". I didn't write the sign-off myself, discovered it was already present when I went back to amend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃憢 @tschaub
(I think it has a sign-off included, but it's a first.)