Add example for StaticImage #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Tsai <tsaiDavid@users.noreply.github.com>
Signed-off-by: Tim Schaub <tim@planet.com>
|
Thanks for the contribution, @tsaiDavid. I pushed another commit to satisfy the linter (need to add docs on the dev setup around that). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tschaub - thanks for your work on this project.
I was able to test these changes locally by booting up Astro via
npm startand see that my example I added was working.As there are currently no typings for this, I referenced both your ol example as well as @crubier's example to try to get a better sense of how this might work.
I am unsure if this is the "right" way to display a static image in this declarative paradigm, so I'm open to any guidance here.