Upgrade to astro@3 #278
Merged
Upgrade to astro@3 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tschaub
commented
Sep 27, 2023
| ], | ||
| "rules": { | ||
| "prettier/prettier": "off" | ||
| } |
There was a problem hiding this comment.
Without disabling the prettier rules, we get errors like this:
2:2 error Parsing error: `import` can only be used in `import()` or `import.meta` prettier/prettier
I've tried configuring the parser and parserOptions, but cannot get the prettier rules to work in conjunction with the the eslint-plugin-astro any more (it worked prior to the Astro upgrade). I'll try to gather details and ticket upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Astro to the latest version.
Fixes #277.