Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animations don't work at all - nav not pinned, no smooth scroll, no tweening #17

Open
kaka-ruto opened this issue Nov 17, 2016 · 8 comments

Comments

@kaka-ruto
Copy link

All the animations created with scrollmagic and tweenmax didn't work for me, neither did pinning or smooth scroling. Terminal didn't throw an error.

@kaka-ruto
Copy link
Author

kaka-ruto commented Nov 17, 2016

I was surprised with the solution to that - after several hours of googling. I found the problem to be with the smooth scroll code from css-tricks, specifically the first line: $('a[href*="#"]:not([href="#"])').click(function()

Now, this selector is not valid. # is a special char and needs to be escaped like a[href*=\\#]:not([href=\\#])

see https://api.jquery.com/category/selectors/

Glad - nav is now pinned, has smooth scrolling and the tweened box animations now work!.

@planetoftheweb
Copy link
Owner

Thanks for the update Collins. Looks like it's due to a change in the new
jQuery. I'll update the gist and the repo.

On Thu, Nov 17, 2016 at 4:24 AM, Collins Kibet notifications@github.com
wrote:

I was surprise with the solution to that - after several hours of
googling. I found the problem to be with the smooth scroll code from
css-tricks, specifically the first line: $('a[href*="#"]:not([href="#"]
)').click(function()

Now, this selector is not valid. # is a special char and needs to be
escaped like 'a[href*=#]:not([href=#])'

see https://api.jquery.com/category/selectors/

Glad it works now.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#17 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANNaq0T7DVuXSLvS0Q7vcipNwBw7YhTks5q_B1cgaJpZM4K1C_-
.

Website http://planetoftheweb.com/ | Flickr
http://flickr.com/planetoftheweb | YouTube
http://youtube.com/planetoftheweb | Twitter
http://twitter.com/planetoftheweb LinkedIn
http://www.linkedin.com/in/planetoftheweb

@kaka-ruto
Copy link
Author

Thanks Ray. I love your tutorials much. They've really improved my
front-end skills by a large margin. Thank you!

On Thu, Nov 17, 2016 at 11:20 PM, Ray Villalobos notifications@github.com
wrote:

Thanks for the update Collins. Looks like it's due to a change in the new
jQuery. I'll update the gist and the repo.

On Thu, Nov 17, 2016 at 4:24 AM, Collins Kibet notifications@github.com
wrote:

I was surprise with the solution to that - after several hours of
googling. I found the problem to be with the smooth scroll code from
css-tricks, specifically the first line: $('a[href*="#"]:not([href="#"]
)').click(function()

Now, this selector is not valid. # is a special char and needs to be
escaped like 'a[href*=#]:not([href=#])'

see https://api.jquery.com/category/selectors/

Glad it works now.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#17 (comment)
261196460>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AANNaq0T7DVuXSLvS0Q7vcipNwBw7YhTks5q_B1cgaJpZM4K1C_->
.

Website http://planetoftheweb.com/ | Flickr
http://flickr.com/planetoftheweb | YouTube
http://youtube.com/planetoftheweb | Twitter
http://twitter.com/planetoftheweb LinkedIn
http://www.linkedin.com/in/planetoftheweb


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#17 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APkGfC3T0fYywIY0pSPVabQEq-25aKcqks5q_LcLgaJpZM4K1C_-
.

@deartet
Copy link

deartet commented Jan 21, 2017

Not exactly an issue but related to smooth scrolling.

I have to minus 1 or above -1 to the topOffset variable make it work and can't figure out why. ><

var scene = new ScrollScene({
triggerElement: '#attractions',
offset: -topOffset-1 // need to minus 1 to make it work
}).setTween(attractionsTween).addTo(controller);

@kaka-ruto
Copy link
Author

kaka-ruto commented Sep 16, 2017 via email

@sami827
Copy link

sami827 commented Oct 2, 2017

Thanks a lot, brother. You were very helpful. Can you give some idea about after completing this course what should I do to master SASS?

@kaka-ruto
Copy link
Author

kaka-ruto commented Oct 2, 2017 via email

@sami827
Copy link

sami827 commented Oct 5, 2017

Thanks a lot, brother. I couldn't even imagine I would get this much help, suggestions from you.I started off with front-end designing and still, I enjoy it.Fortunately, I am not so bad at it. I also learned basic of PHP to take my skill further.Though I am just at the starting point in this development thing.But more than anything I can't show enough gratitude for your help!

Of course, I don't mind. I am from Bangladesh. I know what i am about to say is ridiculous, but if i can help you somehow i would do it.

Thank you for being such a great help! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants