Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set session before throwing an error. #129

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Conversation

iheanyi
Copy link
Member

@iheanyi iheanyi commented Jul 25, 2023

This pull request moves up the session updating after our HTTP requests to be before any error handling. This way, no matter what, the session will always be updated with its proper value.

Fixes #124

@iheanyi iheanyi enabled auto-merge (squash) July 25, 2023 22:03
@iheanyi iheanyi merged commit 216bde0 into main Jul 25, 2023
4 checks passed
@iheanyi iheanyi deleted the iheanyi/fix-transactions branch July 25, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Locks aren't being released when an error is thrown inside a transaction!
3 participants