proxy: ensure Client fields are 64-bit aligned #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes planetscale/surfaces#135 It looks like there is a bug in Go's runtime that happens on 32-bit systems: https://golang.org/pkg/sync/atomic/#pkg-note-BUG It happens if we use 64-bit operations on 64-bit field. On 32-bit architectures, we need to make sure to arrange for 64-bit alignment for atomic access. There is proposal to improve the situation: golang/go#36606 This PR moves the `connectionsCounter` field to the top of the struct and hence makes sure it's guaranteed to be 64-bit aligned.
fatih
force-pushed
the
fatih/fix-field-alignments
branch
from
ad68902
to
beb652c
Compare
mscoutermarsh
approved these changes
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/planetscale/project-big-bang/issues/135
This PR moves the
connectionsCounterfield to the top of the struct and ensures it's guaranteed to be 64-bit aligned.It looks like there is a bug in Go's runtime that happens on 32-bit systems:
https://golang.org/pkg/sync/atomic/#pkg-note-BUG It happens if we use 64-bit operations on a 64-bit field. On 32-bit architectures, we need to make sure to arrange for 64-bit alignment for atomic access. There is a proposal to improve the situation: golang/go#36606